Run a batch file within batch file using VBA (1 Viewer)

W

wasim_sono

Registered User.

Local time

Today, 17:39

Joined

May 29, 2008

Messages

33

• Feb 1, 2018

• #1

Dear all

I have two batch files named as :
1) Combine.bat
2) Picenquiry.bat

The contents of Combine.bat file are as:

Code:Copy to clipboard

@echo off
for %%A in (*.txt) do (
  echo Processing file '%%A'
   
  FOR /F "delims=" %%L in (%%A) do (
    ECHO %%L%%A >> DataFile.txt
  )
)

and contents of Picenquiry.bat are as:

Code:Copy to clipboard

@echo off
ren "F:\meter_pictures\??????rc*." *.txt 
rem call "F:\meter_pictures\combine.bat"

I am using a button on form and following code is used for click on button:

Code:Copy to clipboard

strReportpath = "F:\meter_pictures\"
Shell strReportpath & "Picenquiry.bat"

Unfortunately It runs but only run Picenquiry.bat file and do not run Combine.bat file as it is called in this batch file.

But when I run Picenquiry.bat file directly without using VBA i.e. by double clicking file name, it runs and make "DataFile.txt".

What mistake I am doing? Please help me. Its urgent.

 

Ranman256

Well-known member

Local time

Today, 09:39

Joined

Apr 9, 2015

Messages

4,339

• Feb 1, 2018

• #2

can you not just run both bat in vba?

Shell "F:\meter_pictures\Picenquiry.bat"
shell "F:\meter_pictures\combine.bat"

 

W

wasim_sono

Registered User.

Local time

Today, 17:39

Joined

May 29, 2008

Messages

33

• Feb 1, 2018

• #3

Thanks Ranman256

I did it but same result. rc files converted into text file only. No dataFile is created.

 

J

JHB

Have been here a while

Local time

Today, 15:39

Joined

Jun 17, 2012

Messages

7,732

• Feb 2, 2018

• #4

wasim_sono said:

..and contents of Picenquiry.bat are as:

Code:Copy to clipboard

@echo off
ren "F:\meter_pictures\??????rc*." *.txt 
[B][COLOR=Red]rem[/COLOR][/B] call "F:\meter_pictures\combine.bat"

Click to expand...

You've a Rem in your code. Rem is used when inserting a comments in the code, so it isn't executed.

 

W

wasim_sono

Registered User.

Local time

Today, 17:39

Joined

May 29, 2008

Messages

33

• Feb 2, 2018

• #5

If I remove rem then also same result found.

 

J

JHB

Have been here a while

Local time

Today, 15:39

Joined

Jun 17, 2012

Messages

7,732

• Feb 2, 2018

• #6

wasim_sono said:

If I remove rem then also same result found.

Click to expand...

Okay, but Rem should definitely not be there.
And the . in this line either.

Code:Copy to clipboard

ren "F:\meter_pictures\??????rc*[B][COLOR=red].[/COLOR][/B]" *.txt

Try to run it from a DOS promt, (REM the @echo off line.)
So Picenquiry.bat is:

Code:Copy to clipboard

REM @echo off 
ren "F:\meter_pictures\??????rc*" *.txt  
call "F:\meter_pictures\combine.bat"

 

Cronk

Registered User.

Local time

Today, 23:39

Joined

Jul 4, 2013

Messages

2,771

• Feb 2, 2018

• #7

The original code posted in #1 was

ren "F:\meter_pictures\??????rc*." *.txt
That is trying to give directories file names

Try
ren "F:\meter_pictures\??????rc*.*" *.txt

 

W

wasim_sono

Registered User.

Local time

Today, 17:39

Joined

May 29, 2008

Messages

33

• Feb 6, 2018

• #8

Dear Cronk

Actual problem is that the second line

Code:Copy to clipboard

call "F:\meter_pictures\combine.bat"

is not executing. But it works fine if we run this batch file directly.

 

W

wasim_sono

Registered User.

Local time

Today, 17:39

Joined

May 29, 2008

Messages

33

• Feb 13, 2018

• #9

If anyone can help.

Regards.

 

arnelgp

..forever waiting... waiting for jellybean!

Local time

Today, 21:39

Joined

May 7, 2009

Messages

19,231

• Feb 13, 2018

• #10

in plain language, what does the two .bat files do?

 

Cronk

Registered User.

Local time

Today, 23:39

Joined

Jul 4, 2013

Messages

2,771

• Feb 14, 2018

• #11

From the batch code, it looks like the second batch (Combine.bat) concatenates the text in all text files in the folder to a single file Daily.txt

The first batch file only seems to call the second.

Could use the FileSystemObject as an alternative.