Would someone tell me what's wrong with this

[tgbyhn10]

Have not coded for about 5 years and need a little refresher. Can't remember what I need to do. Thanks

Dim SelectedCompany As String
Dim rs As ADODB.Recordset
Dim Cn As ADODB.Connection
Dim sSql As String

Set rs = New ADODB.Recordset
Set Cn = New ADODB.Connection

SelectedCompany = Me!cboCompanyName.Text

sSql = "select Customername, AddressLine1, AddressLine2, AddressLine3, AddressLine4, AddressLine5, AddressLine6 from customers where "
sSql = sSql & "CompanyName = '" & SelectedCompany & "'"

rs.Open sSql, Cn, adOpenStatic, adLockReadOnly

this last line fails with error "No value given for one or more required parameters."

The code is executed when someone selects something in a combo box on a form in an access database.

Thanks

Pete

 

[boblarson]

One you haven't given your connection object a connection string. But, if you are using the same database you really don't need a connection object. Just change it to this:

rs.Open sSql, [color=red]CurrentProject.Connection[/color], adOpenStatic, adLockReadOnly

And delete the Dim Cn as ADODB.Connection

 

[tgbyhn10]

Is this right?

I don't have any other code or dim statements or anything relating to ado in the project. I'm getting the same error with this.

Dim SelectedCompany As String
Dim rs As ADODB.Recordset
Dim sSql As String

Set rs = New ADODB.Recordset

SelectedCompany = Me!cboCompanyName.Text

sSql = "select Customername, AddressLine1, AddressLine2, AddressLine3, AddressLine4, AddressLine5, AddressLine6 from customers where "
sSql = sSql & "CompanyName = '" & SelectedCompany & "'"

rs.Open sSql, CurrentProject.Connection, adOpenStatic, adLockReadOnly


Thanks for the help

pete

 

[boblarson]

Try this:

sSql = "SELECT CompanyName, Customername, AddressLine1, AddressLine2, AddressLine3, AddressLine4, AddressLine5, AddressLine6 from customers where " & _
"CompanyName = '" & SelectedCompany & "'"

 

[tgbyhn10]

I had messed up the field names and wasn't even looking at them as I though the problem was elsewhere.

Thanks.

All sorted now