whats going wrong? (1 Viewer)

[moose]

Password Form

I have the following code

Private Sub cmdOK_Click() 
'On Error GoTo Err_cmdOK_Click 

If IsNull(Me.TxtName) Or Me.TxtName = "" Then 
    MsgBox "You must enter a User Name.", vbCritical, "User Name Required" 
    Me.TxtName.SetFocus 
    Exit Sub 
End If 
    
If IsNull(Me.txtPassword) Or Me.txtPassword = "" Then 
    MsgBox "You must enter a valid password.", vbCritical, "Enter a valid password." 
    Me.txtPassword.SetFocus 
    Exit Sub 
End If 

If Me.txtPassword.Value = DLookup("strpassword", "TblUsers", "[password] =" & Me.txtPassword.Value) Then 
   Password = Me.txtPassword.Value 
    DoCmd.Close acForm, "FrmPassword", acSaveNo 
    DoCmd.OpenForm "frmadminarea" 
Else 
    MsgBox "Password Invalid, Please try again.", vbCritical, "Invalid Password Entered" 
    Me.txtPassword.SetFocus 
End If 

intlogonattempts = intlogonattempts + 1 
If logonattempts > 3 Then 
    MsgBox "You have entered the wrong password 3 times, Please contact your administrator.", vbCritical, "Access denied!!" 
    Application.Quit 
End If 
Exit sub

but there seems to be something wrong
The debugger points to the "Password = Me.txtPassword.Value" section, but i don't know why
Please help

 

[WayneRyan]

moose,

Just a guess here ...

Dim Pasword As String
Password = Nz(DLookup("[Password]", "TblUsers", "[password] = '" & Me.txtPassword & "'", "")
If Me.txtPassword = Password Then 
   DoCmd.Close acForm, "FrmPassword"
   DoCmd.OpenForm "frmadminarea" 
Else 
    MsgBox "Password Invalid, Please try again.", vbCritical, "Invalid Password Entered" 
    Me.txtPassword.SetFocus 
End If

The Nz function will make sure that (if not found), the Password is
not Null.

I changed the table's field to [Password], I don't think it was strPassWord.

Wayne

 

[moose]

i just get a syntax error now

 

[moose]

I put an extra ) at the end and now get the attached screen

 

[moose]

Below is the full list of my code, can anyone see where it is falling over please

TblUser has the fields ScreenName, Password and the 2 fields on my FrmPassword are TxtName and TxtPassword. I want TxtName to verify the name entered by looking up the screenName field and TxtPassword to lookup the password field.

The code below falls over at the Password = Nz(DLookup point saying Wrong number of arguments or invalid property assignment

PLEASE PLEASE PLEASE HELP

Private Sub cmdOK_Click()
Dim Password As String
Dim intlogonattempts As String

If IsNull(Me.TxtName) Or Me.TxtName = "" Then
MsgBox "You must enter a User Name.", vbCritical, "User Name Required"
Me.TxtName.SetFocus
Exit Sub
End If

If IsNull(Me.txtPassword) Or Me.txtPassword = "" Then
MsgBox "You must enter a valid password.", vbCritical, "Enter a valid password."
Me.txtPassword.SetFocus
Exit Sub
End If

Password = Nz(DLookup("[Password]", "TblUsers", "[password] = '" & Me.txtPassword & "'", ""))

If Me.txtPassword = Password Then
DoCmd.Close acForm, "FrmPassword"
DoCmd.OpenForm "frmadminarea"
Else
MsgBox "Password Invalid, Please try again.", vbCritical, "Invalid Password Entered"
Me.txtPassword.SetFocus
End If

intlogonattempts = intlogonattempts + 1
If intlogonattempts > 3 Then
MsgBox "You have entered the wrong password 3 times, Please contact your administrator.", vbCritical, "Access denied!!"
Application.Quit
End If


If Me.txtPassword = "administrator" Then

DoCmd.Close acForm, Me.Name
DoCmd.OpenForm "FrmAdminArea"

Else

MsgBox "Password Incorrect. Please try again", vbCritical, " Incorrect Password Entered"
Me.txtPassword = ""
Me.TxtName = ""
Me.TxtName.SetFocus
End If

Exit_cmdOK_Click:
Exit Sub

End Sub

 

[Rich]

Password = Nz(DLookup("[Password]", "TblUsers", "[password] = '" & Me.txtPassword & "'", ""))


Try
Password = Nz(DLookup("[Password]", "TblUsers",( "[password] = ' " & Me.txtPassword & " ' ) ") )

 

[moose]

still comes up with Syntax error

 

[Rich]

scrap Password and try If Me.txtPassword = Nz(DLookup("[Password]", "TblUsers",( "[password] = ' " & Me.txtPassword & " ' ) ") )


or try changing
Dim Password As String
to
Dim Password As Variant

 

[moose]

Tried both suggestions and still getting a Syntax Error

 

[Rich]

password = Nz(DLookup("[Password]", "TblUsers", "([password] = '" & Me.txtPassword & "')"))

 

[pdx_man]

Well, I'll toss my 2 cents in to add to the confusion

Please confirm the datatype in the TblUsers table for this field.

Also, Password is a reserved word, and it may be having issues with that. Try UserPassword instead.

 

[Rich]

Tested ok without any error, there are other errors though

 

[pdx_man]

Have you tried:

Password = Nz(DLookup("[Password]", "TblUsers", "[password] = '" & Me.txtPassword & "'"), "")

You have to close your DLookup function before letting the Nz have a go.

 

[moose]

Thanks Rich, your last solution worked fine with only one exception,
Although the form now checks for a valid password (working fine), it still lets you in no matter what user name you enter
Any ideas please

 

[Rich]

You need two conditions, you have to check that the user name matches the password

password = Nz(DLookup("Password", "tblUsers", "([Password] = '" & Me![txtPassword] & "') And ([UserName] = '" & Me![TXTName] & "')"))

 

[moose]

Thanks Rich, I just worked that out as you posted
Thanks for all your help